Many more upload slots open than intended

Submitted by microwave on Fri, 02/06/2015 - 19:30
Forums: 
Soulseek General Discussion

(was: Editing upload speed with slots=1 results in many slots opening)

Sometimes I need to drop down to 1 upload slot with reduced bandwidth. When I tried to do so tonight, something strange happened.

I clicked in the upload slots box and typed "1" (it was 3). Then I clicked in the bandwidth box and type "50" (it was 110). As soon as I typed the "5", it is as if I typed a huge number in the upload slots box. A whole bunch of queued uploads all started simultaneously, and of course they were all crawling. Yet the slots field still said "1".

I've seen this happen before, but always figured I must've rolled the mouse wheel in the upload slots box by accident. But this time, I was running the debug build, and watched it all happen in slow motion, no mouse activity other than the click to get to the field. So I'm sure it happened as soon as I typed the "5" in the KB/s box. I really don't want to try it again though.

Submitted by microwave on Fri, 02/27/2015 - 22:11.

I'm still having occasional problems with too many slots opening up. This time it was as I changed the number of slots only, without touching the upload speed limit.

I started the 2015.2.21 build today, and it had my previous settings: 4 slots open, and the previous limit of 111 still visible but not in effect (checkbox was unchecked).

I didn't pay attention to what downloads started right away; I just immediately clicked the down arrow to change the slots to 3, and I clicked the checkbox to limit the upload speed. This time I didn't click in the Kilobytes Per Second box at all; I just left it at 111.

Then I noticed that everyone's upload speeds were very low, so I scrolled through the queue and saw that somehow everyone in my queue was downloading from me...11 people, even though slots are only at 3! I clicked the checkbox to no longer limit the speed, and watched as a couple of smaller downloads completed, and the client still kept starting new downloads as if there was no limit on the number of slots open.

I noticed a couple of users had already quickly downloaded some small files, so I am thinking maybe this is a problem related to the "Immediately upload files smaller than ___ Kilobytes" setting, which I have set at 1000. I can try disabling that, but this being an intermittent problem, I don't know how to really test it.

Anyway I tried bumping the number of slots back up to 4 and back down to 3, again just using the arrow buttons. Someone new queued something from me, and it immediately started downloading, even though 9 other downloads were still going, so something is very wrong here. Same thing with manually typing 4 in the slots box...someone's download finished and immediately the next item in their queue started downloading, despite there not being enough slots.

I will try the 2015-2-22 build next. (maybe switching between the taglib/non-threaded transfers build and the regular build is exacerbating the problem?)

Submitted by Nir on Sat, 02/28/2015 - 14:06.

Switching between builds shouldn't cause the problem you're describing, but I'm completely unable to reproduce it on my end.. I did change a lot of code related to starting new uploads in the nightly builds, so it might address your problem? If you can lock on a particular way to reproduce this reliably I'll try it out.

Thanks, Nir